uefi: Add safe protocol wrapper for EFI_ATA_PASS_THRU_PROTOCOL #1595
+708
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seijikun
force-pushed
the
mr-atapt
branch
14 times, most recently
from
5d20e04 to
17ff660
Compare
phip1611
reviewed
Mar 28, 2025
phip1611
reviewed
Mar 28, 2025
phip1611
reviewed
Mar 28, 2025
phip1611
reviewed
Mar 28, 2025
phip1611
reviewed
Mar 28, 2025
phip1611
reviewed
Mar 28, 2025
phip1611
requested changes
Mar 28, 2025
seijikun
force-pushed
the
mr-atapt
branch
2 times, most recently
from
2ccfb33 to
6a82a32
Compare
2 tasks
seijikun
force-pushed
the
mr-atapt
branch
2 times, most recently
from
4e64767 to
9a64ab4
Compare
phip1611
changed the title
phip1611
reviewed
Apr 8, 2025
phip1611
reviewed
Apr 8, 2025
seijikun
force-pushed
the
mr-atapt
branch
2 times, most recently
from
8ab0d94 to
1e5d815
Compare
phip1611
reviewed
Apr 8, 2025
phip1611
reviewed
Apr 10, 2025
phip1611
reviewed
Apr 10, 2025
xtask/src/qemu.rs
Outdated
| @@ -489,6 +489,18 @@ pub fn run_qemu(arch: UefiArch, opt: &QemuOpt) -> Result<()> { | |||
| cmd.arg("-device"); // attach disk to SCSI controller | |||
| cmd.arg("scsi-hd,drive=scsidisk0,vendor=uefi-rs,product=ExtScsiPassThru"); | |||
|
|
|||
| if arch == UefiArch::IA32 || arch == UefiArch::X86_64 { | |||
There was a problem hiding this comment.
What happens on AARCH64? Does QEMU only support the ATA controller on x86?
There was a problem hiding this comment.
Getting it to work is difficult because the default hardware configuration between x86 and arm is quite different. And since (at least afaik) I can't run it locally, I would need to push 1000 times to get it working. I'll try again
There was a problem hiding this comment.
Qemu seems to support having a SATA controller with aarch64.
But the UEFI firmware does not produce an AtaPassThru instance for the controller. So it seems that EDK2 is at fault. I'll document it.
seijikun
force-pushed
the
mr-atapt
branch
5 times, most recently
from
530521a to
dd50f86
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Latest API discussions
Implemented a safe API wrapper for
EFI_ATA_PASS_THRU_PROTOCOL[1d3de7f0-0807-424f-aa69-11a54e19a46f].Added an integration-test for it.
This contains a copy of the AlignedBuffer commit from #1589.
This uses the iterator/mutable design I suggested here: #1589 (comment) where the iter method only captures the protocol (
AtaPassThru) immutably, but requires you to use the produced element (AtaDevice) in a mutable way for meaningful methods like execute_command.This closes #244
Checklist